Skip to content

[Linkedin Audiences] - Company Audience Sync Action #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

[Linkedin Audiences] - Company Audience Sync Action #3352

wants to merge 21 commits into from

Conversation

@joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Oct 17, 2025 •
edited
Loading

Account Based Marketing / Company Action

  1. New Action to handle account based Segment Audience -> LinkedIn Company Segments
  • handles multistatus responses
  1. Existing User Audience Action
  • Refactored and added multistatus response handling
  • Added batch_key field and hid the personas_audience_key field

Testing

Unit tests

  1. Account Based Marketing / Company Action
  • Full coverage with unit tests (batch and non batch events)
  1. Existing User Audience Action
  • Updated existing single event tests so they pass
  • Added batch tests

Testing in Staging

  • WIP

@joe-ayoub-segment joe-ayoub-segment self-assigned this Oct 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025 •
edited
Loading

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Linkedin Audiences, Action Field(s):identifiers,segment_creation_name,computation_key,traits_or_props,computation_class,batch_keys

Add these new fields as optional instead and assume default values in perform or performBatch block.

@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.79470% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.98%. Comparing base (4ceb00c) to head (65b1b1a).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...estinations/linkedin-audiences/common-functions.ts 56.86% 18 Missing and 4 partials ⚠️
...ons/linkedin-audiences/updateAudience/functions.ts 88.46% 3 Missing and 3 partials ⚠️
...actions/src/destinations/linkedin-audiences/api.ts 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3352   +/-   ##
=======================================
  Coverage   79.98%   79.98%           
=======================================
  Files        1206     1211    +5     
  Lines       22336    22397   +61     
  Branches     4410     4420   +10     
=======================================
+ Hits        17866    17915   +49     
- Misses       3686     3702   +16     
+ Partials      784      780    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joe-ayoub-segment joe-ayoub-segment marked this pull request as ready for review October 23, 2025 13:46
@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner October 23, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsh-joshi99 harsh-joshi99 Awaiting requested review from harsh-joshi99

@varadarajan-tw varadarajan-tw Awaiting requested review from varadarajan-tw

At least 1 approving review is required to merge this pull request.

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels

deploy:push mode:cloud partner-eng-review (cloud) team:segment-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joe-ayoub-segment